Fix: Flapping addon staus due to 409 response on remote write to the hub #1777
Conversation
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: philipgough, saswatamcode, thibaultmg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Thibault Mange <[email protected]>
thibaultmg
force-pushed
the
ACM_17055_flipping_status_409
branch
from
56d68f0 to
09f3bb2
Compare
|
New changes are detected. LGTM label has been removed. |
|
|
@thibaultmg: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-2.12 |
|
@thibaultmg: new pull request created: #1780 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Status from the metrics collector now reports available state when receiving a 409 http error on remote write to the hub.
This reflects more accurately the status of the addon as metrics are well ingested. The error is still logged to make it visible as this is most often the result of an invalid configuration.
Fixes https://issues.redhat.com/browse/ACM-17055